Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do simple logging for failed export. #1480

Merged
merged 3 commits into from
Jul 31, 2020
Merged

Do simple logging for failed export. #1480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
504a823
Simple logging for failed export.
carlosalberto Jul 29, 2020
0368d5a
Merge branch 'master' into log_failed_export
carlosalberto Jul 29, 2020
bea929d
Use WARNING instead of SEVERE.
carlosalberto Jul 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions exporters/jaeger/src/main/java/io/opentelemetry/exporters/jaeger/JaegerGrpcSpanExporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ public ResultCode export(Collection<SpanData> spans) {
stub.postSpans(request);
return ResultCode.SUCCESS;
} catch (Throwable e) {
logger.log(Level.WARNING, "Failed to export spans", e);
return ResultCode.FAILURE;
}
}
Expand Down
1 change: 1 addition & 0 deletions exporters/otlp/src/main/java/io/opentelemetry/exporters/otlp/OtlpGrpcMetricExporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ public ResultCode export(Collection<MetricData> metrics) {
stub.export(exportMetricsServiceRequest);
return ResultCode.SUCCESS;
} catch (Throwable e) {
logger.log(Level.WARNING, "Failed to export metrics", e);
return ResultCode.FAILURE;
}
}
Expand Down
1 change: 1 addition & 0 deletions exporters/otlp/src/main/java/io/opentelemetry/exporters/otlp/OtlpGrpcSpanExporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ public ResultCode export(Collection<SpanData> spans) {
stub.export(exportTraceServiceRequest);
return ResultCode.SUCCESS;
} catch (Throwable e) {
logger.log(Level.WARNING, "Failed to export spans", e);
return ResultCode.FAILURE;
}
}
Expand Down
1 change: 1 addition & 0 deletions exporters/zipkin/src/main/java/io/opentelemetry/exporters/zipkin/ZipkinSpanExporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,7 @@ public ResultCode export(final Collection<SpanData> spanDataList) {
try {
sender.sendSpans(encodedSpans).execute();
} catch (Exception e) {
logger.log(Level.WARNING, "Failed to export spans", e);
return ResultCode.FAILURE;
}
return ResultCode.SUCCESS;
Expand Down