Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename contrib to extensions #1335

Merged
merged 5 commits into from
Jun 17, 2020

Conversation

iNikem
Copy link
Contributor

@iNikem iNikem commented Jun 15, 2020

Closes #1100

@codecov
Copy link

codecov bot commented Jun 15, 2020

Codecov Report

Merging #1335 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1335      +/-   ##
============================================
- Coverage     92.30%   92.29%   -0.02%     
+ Complexity      917      914       -3     
============================================
  Files           118      118              
  Lines          3209     3204       -5     
  Branches        262      261       -1     
============================================
- Hits           2962     2957       -5     
  Misses          165      165              
  Partials         82       82              
Impacted Files Coverage Δ Complexity Δ
...ions/trace/export/DisruptorAsyncSpanProcessor.java 86.00% <ø> (ø) 10.00 <0.00> (?)
...k/extensions/trace/export/DisruptorEventQueue.java 83.51% <ø> (ø) 12.00 <0.00> (?)
...ions/trace/jaeger/sampler/JaegerRemoteSampler.java 72.54% <ø> (ø) 9.00 <0.00> (?)
...ions/trace/jaeger/sampler/PerOperationSampler.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...k/extensions/trace/jaeger/sampler/RateLimiter.java 94.11% <ø> (ø) 4.00 <0.00> (?)
...ions/trace/jaeger/sampler/RateLimitingSampler.java 63.63% <ø> (ø) 6.00 <0.00> (?)
...ensions/trace/jaeger/sampler/SamplingDecision.java 100.00% <ø> (ø) 3.00 <0.00> (?)
...emetry/sdk/extensions/otproto/TraceProtoUtils.java 81.48% <ø> (ø) 6.00 <0.00> (?)
...o/opentelemetry/common/ImmutableKeyValuePairs.java 88.37% <0.00%> (-0.99%) 15.00% <0.00%> (-3.00%)
...ntelemetry/sdk/trace/RecordEventsReadableSpan.java 92.57% <0.00%> (-0.09%) 62.00% <0.00%> (ø%)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f68d90...f24aea1. Read the comment docs.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@carlosalberto
Copy link
Contributor

Overall good, but I'm wondering whether we should adjust the names for some of these packages, i.e. OpenTelemetry Contrib Auto Annotations became OpenTelemetry Extension Auto Annotations doesn't quite feel right ;)

@iNikem
Copy link
Contributor Author

iNikem commented Jun 15, 2020

Overall good, but I'm wondering whether we should adjust the names for some of these packages, i.e. OpenTelemetry Contrib Auto Annotations became OpenTelemetry Extension Auto Annotations doesn't quite feel right ;)

All suggestions are welcomed.

@jkwatson
Copy link
Contributor

looks like it needs a rebase. I like it, though!

@iNikem
Copy link
Contributor Author

iNikem commented Jun 16, 2020

looks like it needs a rebase. I like it, though!

Done.

@carlosalberto
Copy link
Contributor

Since it's a relatively important change, lets wait a little while before merging it, so people can comment/review ;)

@iNikem
Copy link
Contributor Author

iNikem commented Jun 17, 2020

Ready to merge?

@carlosalberto carlosalberto merged commit c558a96 into open-telemetry:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename contrib and sdk_contrib
4 participants