Skip to content

Commit

Permalink
Do simple logging for failed export. (#1480)
Browse files Browse the repository at this point in the history
* Simple logging for failed export.

* Use WARNING instead of SEVERE.
  • Loading branch information
carlosalberto authored Jul 31, 2020
1 parent 0f322b3 commit 199df3a
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ public ResultCode export(Collection<SpanData> spans) {
stub.postSpans(request);
return ResultCode.SUCCESS;
} catch (Throwable e) {
logger.log(Level.WARNING, "Failed to export spans", e);
return ResultCode.FAILURE;
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ public ResultCode export(Collection<MetricData> metrics) {
stub.export(exportMetricsServiceRequest);
return ResultCode.SUCCESS;
} catch (Throwable e) {
logger.log(Level.WARNING, "Failed to export metrics", e);
return ResultCode.FAILURE;
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ public ResultCode export(Collection<SpanData> spans) {
stub.export(exportTraceServiceRequest);
return ResultCode.SUCCESS;
} catch (Throwable e) {
logger.log(Level.WARNING, "Failed to export spans", e);
return ResultCode.FAILURE;
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,7 @@ public ResultCode export(final Collection<SpanData> spanDataList) {
try {
sender.sendSpans(encodedSpans).execute();
} catch (Exception e) {
logger.log(Level.WARNING, "Failed to export spans", e);
return ResultCode.FAILURE;
}
return ResultCode.SUCCESS;
Expand Down

0 comments on commit 199df3a

Please sign in to comment.