Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HttpClientAttributesGetter extend NetClientAttributesGetter #9015

Merged

Conversation

mateuszrzeszutek
Copy link
Member

Part of #9013

95% of this PR is just moving code around, there should hardly be any new stuff added

@mateuszrzeszutek mateuszrzeszutek requested a review from a team July 21, 2023 15:09
@mateuszrzeszutek mateuszrzeszutek force-pushed the make-http-client-getter-extend-net branch 2 times, most recently from e8a06cc to 6870e5a Compare July 26, 2023 14:50
@mateuszrzeszutek mateuszrzeszutek force-pushed the make-http-client-getter-extend-net branch from 6870e5a to eb8558f Compare July 31, 2023 07:19
@trask
Copy link
Member

trask commented Jul 31, 2023

/easycla

@trask trask merged commit d816303 into open-telemetry:main Jul 31, 2023
44 checks passed
@mateuszrzeszutek mateuszrzeszutek deleted the make-http-client-getter-extend-net branch August 1, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants