Lettuce instrumentation - optimization to avoid extra toString() #8984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
commented
Jul 19, 2023
Comment on lines
+42
to
+43
| ValueArgument valueArg = (ValueArgument) argument; | ||
| return stringCodec.decodeValue(valueArg.codec.encodeValue(valueArg.val)); |
There was a problem hiding this comment.
Taken from the existing source of ValueArgument.toString(). One note: the codec is being reused here to avoid allocations.
There was a problem hiding this comment.
I initially implemented it similarly to what you have done but chose to use substring because of simplicity and reduced dependency on lettuce internals.
There was a problem hiding this comment.
Yeah, agreed that this feels a tad more fragile. Hopefully it's a fair trade off for performance tho.
mateuszrzeszutek
approved these changes
Jul 20, 2023
laurit
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #8907
The instrumentation was calling
SingularArgument.toString()for every argument. In the case ofKeyArgumentandValueArgument, the implementations oftoString()serve only to wrap the value in a string literalkey<...>orvalue<...>(respectively), which we then parsed back out.So this change doesn't call
toString()in those two cases, instead jumping right to the contents (essentially inlining the important part of thetoString()implementation from the lettuce source). This both bypasses the extra parsing/unwrapping but also eliminates aString.format()that generated it in the first place.All other argument types still use the vanilla toString() approach.