Skip to content

Fix possible NPE #8199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2023
Merged

Fix possible NPE #8199

merged 1 commit into from
Apr 3, 2023

Conversation

trask
Copy link
Member

@trask trask commented Apr 3, 2023

this is a follow-up to #7043

I tried to add a test when that PR was opened:

but it doesn't really verify anything, since the NPE is throw/caught and same behavior occurs

@trask trask requested a review from a team April 3, 2023 00:09
@mateuszrzeszutek mateuszrzeszutek merged commit 70cd846 into open-telemetry:main Apr 3, 2023
@trask trask deleted the fix-npe branch July 10, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trask @mateuszrzeszutek