Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Open Liberty 21.0.0.12 and 22.0.0.12 #7878

Merged
merged 4 commits into from
Feb 22, 2023

Conversation

fmhwong
Copy link
Contributor

@fmhwong fmhwong commented Feb 22, 2023

Add newer Open Liberty images 21.0.0.12 and 22.0.0.12.

@fmhwong fmhwong requested a review from a team February 22, 2023 17:17
ImageTarget(listOf("21.0.0.12"), listOf("openj9"), listOf("8", "11", "17"), mapOf("release" to "2021-11-17_1256")),
// Java 19 is not supported until 22.0.0.10
ImageTarget(listOf("22.0.0.12"), listOf("hotspot"), listOf("8", "11", "17", "19"), mapOf("release" to "22.0.0.12")),
ImageTarget(listOf("22.0.0.12"), listOf("openj9"), listOf("8", "11", "17", "19"), mapOf("release" to "22.0.0.12")),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build is failing with

Could not build image: manifest for ibm-semeru-runtimes:open-19-jdk not found: manifest unknown: manifest unknown
Suggested change
ImageTarget(listOf("22.0.0.12"), listOf("openj9"), listOf("8", "11", "17", "19"), mapOf("release" to "22.0.0.12")),
ImageTarget(listOf("22.0.0.12"), listOf("openj9"), listOf("8", "11", "17"), mapOf("release" to "22.0.0.12")),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized Semeru runtime doesn't have Java 19 yet.

@trask trask merged commit 5845d98 into open-telemetry:main Feb 22, 2023
@trask
Copy link
Member

trask commented Feb 22, 2023

@fmhwong I just merged, when this build finished, the new images should be available: https://github.com/open-telemetry/opentelemetry-java-instrumentation/actions/runs/4247218894

@fmhwong fmhwong deleted the addNewLibertyImages branch February 23, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants