Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load jdk http server classes from platform class loader #5408

Merged
merged 1 commit into from
Feb 19, 2022
Merged

Load jdk http server classes from platform class loader #5408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 33 additions & 1 deletion javaagent-bootstrap/src/main/java/io/opentelemetry/javaagent/bootstrap/AgentClassLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
import java.io.FileNotFoundException;
import java.io.IOException;
import java.io.InputStream;
import java.lang.reflect.InvocationTargetException;
import java.lang.reflect.Method;
import java.net.MalformedURLException;
import java.net.URL;
import java.net.URLClassLoader;
Expand Down Expand Up @@ -71,7 +73,7 @@ public class AgentClassLoader extends URLClassLoader {
* @param internalJarFileName File name of the internal jar
*/
public AgentClassLoader(File javaagentFile, String internalJarFileName) {
super(new URL[] {}, null);
super(new URL[] {}, getParentClassLoader());
if (javaagentFile == null) {
throw new IllegalArgumentException("Agent jar location should be set");
}
Expand Down Expand Up @@ -113,6 +115,36 @@ public AgentClassLoader(File javaagentFile, String internalJarFileName) {
}
}

private static ClassLoader getParentClassLoader() {
if (JAVA_VERSION > 8) {
ClassLoader platformClassLoader = getPlatformLoader();
return new ClassLoader(null) {
@Override
protected Class<?> loadClass(String name, boolean resolve) throws ClassNotFoundException {
// prometheus exporter uses jdk http server, load it from the platform class loader
if (name != null && name.startsWith("com.sun.net.httpserver.")) {
return platformClassLoader.loadClass(name);
}
return super.loadClass(name, resolve);
}
};
}
return null;
}

private static ClassLoader getPlatformLoader() {
/*
Must invoke ClassLoader.getPlatformClassLoader by reflection to remain
compatible with java 8.
*/
try {
Method method = ClassLoader.class.getDeclaredMethod("getPlatformClassLoader");
return (ClassLoader) method.invoke(null);
} catch (InvocationTargetException | NoSuchMethodException | IllegalAccessException exception) {
throw new IllegalStateException(exception);
}
}

private static int getJavaVersion() {
String javaSpecVersion = System.getProperty("java.specification.version");
if ("1.8".equals(javaSpecVersion)) {
Expand Down