GraphQL Java Instrumentation #4337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
# Conflicts: # docs/supported-libraries.md
|
I want to finish this by Sunday the 23rd as Spring for GraphQL 1.0.0-M5 and Spring Boot 3.0.0-M1 (which will probably include 1.0.0-M5) are approaching. |
|
Will be closing this because it has been implemented in #5583 . I was busy with school and other open source contributions. Thank you Lauri! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4270 (The issue addressing GraphQL Java Instrumentation).
This PR is WIP. Will be marked ready for review when it is ready.
This will probably take somewhere between three weeks and two months since I am doing it in my free time and have exams coming up (I am making the commitment though).
References:
Library targeted:
https://github.com/graphql-java/graphql-java
Presently only version 17.x is supported, thus the PR will target version 17. If 18.x is released before the PR is finished, I will try to add support for both.
Frameworks targeted:
Not targeted:
Library instrumentation will be implemented using native graphql-java instrumentation.
Agent instrumentation will be provided by chaining the library instrumentation using ChainedInstrumentation, or a custom delegate class in order to bypass looping done in ChainedInstrumentation. The instrumentation will be injected after the GraphQL object is constructed (Is this even possible? We will find out, otherwise we will target the GraphQL$Builder#build() method).
Feel free to reach out with any concerns, either via the original issue or this PR.