Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webflux to Instrumenter API (and improvements/simplifications) #3798

Merged
merged 17 commits into from
Aug 13, 2021
Merged
Prev Previous commit
Next Next commit
Fix comment
  • Loading branch information
trask committed Aug 10, 2021
commit df2cfa82d02f5b2a0c4d47b183e5f6ba866263e9
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ public static void methodExit(
@Advice.Argument(0) ServerWebExchange exchange,
@Advice.Return(readOnly = false) Mono<Void> mono) {
if (mono != null) {
// note: it seems like this code should go in HandleAdvice @OnMethodExit
// but for some reason "GET to bad endpoint annotation API fail Mono" test fails
// with that placement
// note: it seems like this code should go in @OnMethodExit of
// HandlerAdapterInstrumentation.HandleAdvice instead, but for some reason "GET to bad
// endpoint annotation API fail Mono" test fails with that placement
mono = AdviceUtils.end(mono, exchange);
}
}
Expand Down