Migrate from spotbugs to errorprone #3122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
requested review from
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
| @@ -102,7 +102,7 @@ public static void onEnter( | |||
| } | |||
|
|
|||
| // Assume already instrumented event if traceId is present. | |||
| if (!mdc.contains(TRACE_ID)) { | |||
| if (!mdc.containsValue(TRACE_ID)) { | |||
There was a problem hiding this comment.
Ouch, that's a bug - it should've been containsKey() right from the start
There was a problem hiding this comment.
Error prone to the rescue!
mateuszrzeszutek
approved these changes
May 28, 2021
|
|
||
| } catch (Exception e) { | ||
| log.debug("Instrumentation error in tracing consumer", e); | ||
| try { |
There was a problem hiding this comment.
Nit: we can use try-with-resources here
There was a problem hiding this comment.
done (so I can merge this before #3118)
Comment on lines
-74
to
-75
| // TODO this is very unusual code structure for this repo | ||
| // We have to review it |
trask
approved these changes
May 28, 2021
robododge
pushed a commit
to robododge/opentelemetry-java-instrumentation
that referenced
this pull request
Jun 17, 2021
* Migrate from spotbugs to errorprone * Fix hashtable * try-with-resources * Fix from merge Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistent with SDK, prints errors to console instead of file, and easier to SuppressWarnings