Do not use arrays in InstrumentationModule #3057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
pavolloffay,
trask and
tylerbenson
as code owners
mateuszrzeszutek
force-pushed
the
dont-use-arrays-in-instrumentation-module
branch
from
31ea56b to
09d9a9b
Compare
trask
approved these changes
May 21, 2021
Comment on lines
-76
to
+74
| return new GenerateMuzzleMethodsAndFields( | ||
| classVisitor, | ||
| implementationContext.getClassFileVersion().isAtLeast(ClassFileVersion.JAVA_V6)); | ||
| return new GenerateMuzzleMethodsAndFields(classVisitor); |
| @@ -47,7 +46,6 @@ | |||
| class MuzzleCodeGenerator implements AsmVisitorWrapper { | |||
| private static final Logger log = LoggerFactory.getLogger(MuzzleCodeGenerator.class); | |||
|
|
|||
| private static final String MUZZLE_REFERENCES_FIELD_NAME = "muzzleReferences"; | |||
Comment on lines
-563
to
+504
| mv.visitTypeInsn(Opcodes.NEW, "java/util/HashMap"); | ||
| // stack: map | ||
| mv.visitInsn(Opcodes.DUP); | ||
| // stack: map, map | ||
| mv.visitLdcInsn(contextStoreClasses.size()); | ||
| // stack: map, map, size | ||
| mv.visitMethodInsn(Opcodes.INVOKESPECIAL, "java/util/HashMap", "<init>", "(I)V", false); | ||
| writeNewMap(mv, contextStoreClasses.size()); |
| // stack: map | ||
| mv.visitInsn(Opcodes.DUP); | ||
| // stack: map, map | ||
| // pass bigger size to avoid resizes; same formula as in e.g. HashSet(Collection) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InstrumentationModule, it now uses lists & maps.muzzleReferencesfield:MuzzleMatchermaintains a reference toReferenceMatcher, there's no need to keep the reference to the collection of classrefs anymore.MuzzleCodeGeneratorto private methods.