Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record internal metric for SQL cache misses #2747

Merged
merged 3 commits into from
Apr 8, 2021
Merged

Record internal metric for SQL cache misses #2747

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
738c6d5
Record internal metric for SQL cache misses
Apr 7, 2021
daf6f4e
Fix broken shouldStart() logic
Apr 7, 2021
d0a403b
Code review comments
Apr 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix broken shouldStart() logic
  • Loading branch information
Mateusz Rzeszutek committed Apr 7, 2021
commit daf6f4e39604981b4fb3e8f52e9f6113b0b9f81a
4 changes: 2 additions & 2 deletions ...ion-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/Instrumenter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,10 @@ public boolean shouldStart(Context parentContext, REQUEST request) {
SpanKind spanKind = spanKindExtractor.extract(request);
switch (spanKind) {
case SERVER:
suppressed = ServerSpan.fromContextOrNull(parentContext) == null;
suppressed = ServerSpan.fromContextOrNull(parentContext) != null;
break;
case CLIENT:
suppressed = ClientSpan.fromContextOrNull(parentContext) == null;
suppressed = ClientSpan.fromContextOrNull(parentContext) != null;
break;
default:
break;
Expand Down