Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing Unroll annotations #2383

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Add missing Unroll annotations #2383

merged 1 commit into from
Feb 23, 2021

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Feb 23, 2021

No description provided.

@iNikem
Copy link
Contributor

iNikem commented Feb 23, 2021

@trask Did not we have some auto unroll or something?

trask
trask approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trask Did not we have some auto unroll or something?

that would be nice, but doesn't ring a bell

@mateuszrzeszutek
Copy link
Member

If we add @Unroll to the InstrumentationSpecification it'll probably work everywhere

@laurit
Copy link
Contributor Author

laurit commented Feb 23, 2021

Without unroll method is run for both parameters given in where section, but in test report method is present only once and #methodName is not replaced in its name. With unroll test report has 2 method and #methodName is replaced with parameter.
@iNikem maybe you meant https://github.com/szpak/spock-global-unroll

@iNikem
Copy link
Contributor

iNikem commented Feb 23, 2021

@iNikem maybe you meant https://github.com/szpak/spock-global-unroll

Yes, I was sure we had this 🤔

@iNikem iNikem merged commit e652cb4 into open-telemetry:main Feb 23, 2021
@laurit laurit deleted the missing-unroll branch August 24, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@iNikem iNikem iNikem approved these changes

@trask trask trask approved these changes

@anuraaga anuraaga Awaiting requested review from anuraaga

@jkwatson jkwatson Awaiting requested review from jkwatson

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laurit @iNikem @mateuszrzeszutek @trask