Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HttpServerTest.testExceptionBody and redirectHasBody #2346

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Remove HttpServerTest.testExceptionBody and redirectHasBody #2346

merged 1 commit into from
Feb 19, 2021

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Feb 19, 2021

Closes #2343

anuraaga
anuraaga approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great simplification

@iNikem iNikem merged commit 1ca7276 into open-telemetry:main Feb 19, 2021
@laurit laurit deleted the remove-testExceptionBody branch August 24, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iNikem iNikem iNikem approved these changes

@anuraaga anuraaga anuraaga approved these changes

@jkwatson jkwatson Awaiting requested review from jkwatson

@mateuszrzeszutek mateuszrzeszutek Awaiting requested review from mateuszrzeszutek

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@trask trask Awaiting requested review from trask

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove HttpServerTest.testExceptionBody
3 participants
@laurit @anuraaga @iNikem