convert instrument jdbc test from groovy to java

[shalk]

relate to #7195

[shalk]

It is look like

:instrumentation:couchbase:couchbase-2.6:javaagent:test

failed by Address already in use.

It is not break by jdbc test. the jdc case is all memory server

[laurit]

I'm not sure about the value of this. Spock is able to replace #connection.getClass().getCanonicalName() and #system with actual parameter values so you'd have a test named prepared statement execute on h2 with org.h2.jdbc.JdbcConnection generates a span with junit this does not happen

[shalk]

junit can not do the same ability，like getCannicalname。

Junit is a tree struct， DisplayName for the method， parametertest have each name。

I do not found the usage in other tests in the projects。

[laurit]

I don't think you understood. When you run the groovy tests in intellij then the main test is named basic statement with #connection.getClass().getCanonicalName() on #system generates spans when you expand it then you see the test with parameters. They are named basic statement with org.h2.jdbc.JdbcConnection on h2 generates spans. When you run the junit test the main test name is what you set in display name and when you expand it you'll just see the parameters. That is why I believe that using the @DisplayName they way you do does not make sense. There is no magic interpolation like in spock. You might either not add @DisplayName at all or change it to @DisplayName("basic statement generates spans")

[shalk]

i will remove @DisplayName

[laurit]

the original groovy test uses

if (username != null) {
  "$DbIncubatingAttributes.DB_USER" username
}

If username is given verify that this attribute exists, your assertion just makes user name optional.

[shalk]

done

[laurit]

as far as I can tell you only fixed it in some places

[shalk]

let me see

[laurit]

other tests use

    cleanup.deferCleanup(statement);
    cleanup.deferCleanup(connection);

[shalk]

junit will autoclose connection on method parameter

I only add

 cleanup.deferCleanup(statement);

[laurit]

That is fine.
To me it feels a bit odd that there is a bunch of tests where connection is passes as parameter and still use cleanup.deferCleanup(connection); and there is one test that does not do it. Perhaps remove it from other tests also where it is not needed?