support otel.instrumentation.kafka.experimental-span-attributes in spring starter #11263
Conversation
github-actions
bot
added
the
test native
There was a problem hiding this comment.
@zeitlinger Would it be possible to add an automatic test? Perhaps in another PR?
yes, I can add it in #11262 |
zeitlinger
force-pushed
the
spring-kafka-experimental-span-attributes
branch
2 times, most recently
from
79575ac
to
c8b34e1
Compare
zeitlinger
force-pushed
the
spring-kafka-experimental-span-attributes
branch
from
c8b34e1
to
4185f83
Compare
…compatible with all spring versions, honors properties customizers, and easier to find usages
zeitlinger
force-pushed
the
spring-kafka-experimental-span-attributes
branch
from
4185f83
to
8271414
Compare
it's now tested here: https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/11263/files#diff-23bb7021e8d17c3bda9c13eb1c42019ba2a666e22da6a8d6da97ce4717612546R101 |
...va/io/opentelemetry/instrumentation/spring/autoconfigure/OpenTelemetryAutoConfiguration.java
Show resolved
Hide resolved
...va/io/opentelemetry/instrumentation/spring/autoconfigure/OpenTelemetryAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...utoconfigure/instrumentation/kafka/ConcurrentKafkaListenerContainerFactoryPostProcessor.java
Show resolved
Hide resolved
...va/io/opentelemetry/instrumentation/spring/autoconfigure/OpenTelemetryAutoConfiguration.java
Show resolved
Hide resolved
| * Expose the {@link ConfigProperties} bean for use in other auto-configurations. | ||
| * | ||
| * <p>Why not use spring boot properties directly? <br> | ||
| * 1. issues with older spring boot versions <br> |
There was a problem hiding this comment.
wouldn't these issues affect our (broader) usage of spring boot properties to configure the SDK?
There was a problem hiding this comment.
merging to unblock #11350, but i'd be in favor of removing this bullet (or explaining it better), since as written I think it creates more questions than it answers
There was a problem hiding this comment.
it's this style that silently returns false in boot 2
@Value("${otel.instrumentation.common.db-statement-sanitizer.enabled:true}")
There was a problem hiding this comment.
wouldn't these issues affect our (broader) usage of spring boot properties to configure the SDK?
no
There was a problem hiding this comment.
i'd be in favor of removing this bullet (or explaining it better), since as written I think it creates more questions than it answers
| * 1. issues with older spring boot versions <br> |
Depends #11262