Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RxJava 2 instrumentation Android-friendly #7894

Closed
bherbst opened this issue Feb 23, 2023 · 0 comments · Fixed by #7895
Closed

Make RxJava 2 instrumentation Android-friendly #7894

bherbst opened this issue Feb 23, 2023 · 0 comments · Fixed by #7895
Labels
enhancement New feature or request

Comments

@bherbst
Copy link
Contributor

bherbst commented Feb 23, 2023

The RxJava2 instrumentation uses MethodHandle, which was introduced in Java 8. This makes the instrumentation incompatible with Android applications that support Android API versions older than API 26 (Android 8.0).

Because RxJava is quite popular within the Android community, being able to use the instrumentation on Android is highly desirable.
@bherbst bherbst added the enhancement New feature or request label Feb 23, 2023
@bherbst bherbst mentioned this issue Feb 23, 2023
Merged
laurit pushed a commit that referenced this issue Feb 24, 2023
@bherbst @opentelemetrybot
Make RxJava2 instrumentation Android-friendly (#7895)
ba9df3f 
Resolves #7894

Replace `MethodHandle` with older `java.lang.reflect.Field`, which is
supported on older Java versions.

Also enables animal sniffer for the RxJava2 instrumentation to prevent
regression.

---------

Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make RxJava2 instrumentation Android-friendly bherbst/opentelemetry-java-instrumentation
1 participant
@bherbst