Skip to content

Commit

Permalink
Minor rename of javaagent unit test modules (#2784)
Browse files Browse the repository at this point in the history
  • Loading branch information
trask authored Apr 13, 2021
1 parent eb81e89 commit d741dc4
Show file tree
Hide file tree
Showing 16 changed files with 13 additions and 13 deletions.
6 changes: 3 additions & 3 deletions docs/contributing/writing-instrumentation.md
Original file line number Diff line number Diff line change
Expand Up @@ -128,16 +128,16 @@ Ideally javaagent instrumentation is just a thin wrapper over library instrument
is no need to write unit tests that directly access the javaagent instrumentation classes.

If you still want to write a unit test against javaagent instrumentation, add another module
named `javaagent-unittests`. Continuing with the example above:
named `javaagent-unit-tests`. Continuing with the example above:

```
instrumentation ->
...
yarpc-1.0 ->
javaagent
yarpc-1.0-javaagent.gradle
javaagent-unittest
yarpc-1.0-javaagent-unittest.gradle
javaagent-unit-tests
yarpc-1.0-javaagent-unit-tests.gradle
...
```

Expand Down
20 changes: 10 additions & 10 deletions settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ include ':smoke-tests'
include ':instrumentation:akka-actor-2.5:javaagent'
include ':instrumentation:akka-http-10.0:javaagent'
include ':instrumentation:apache-camel-2.20:javaagent'
include ':instrumentation:apache-camel-2.20:javaagent-unittests'
include ':instrumentation:apache-camel-2.20:javaagent-unit-tests'
include ':instrumentation:apache-dubbo:apache-dubbo-2.7:javaagent'
include ':instrumentation:apache-dubbo:apache-dubbo-2.7:library'
include ':instrumentation:apache-dubbo:apache-dubbo-2.7:testing'
Expand All @@ -76,7 +76,7 @@ include ':instrumentation:aws-lambda-1.0:javaagent'
include ':instrumentation:aws-lambda-1.0:library'
include ':instrumentation:aws-lambda-1.0:testing'
include ':instrumentation:aws-sdk:aws-sdk-1.11:javaagent'
include ':instrumentation:aws-sdk:aws-sdk-1.11:javaagent-unittests'
include ':instrumentation:aws-sdk:aws-sdk-1.11:javaagent-unit-tests'
include ':instrumentation:aws-sdk:aws-sdk-1.11:library'
include ':instrumentation:aws-sdk:aws-sdk-1.11:testing'
include ':instrumentation:aws-sdk:aws-sdk-2.2:javaagent'
Expand All @@ -87,9 +87,9 @@ include ':instrumentation:cassandra:cassandra-4.0:javaagent'
include ':instrumentation:cdi-testing'
include ':instrumentation:classloaders:javaagent'
include ':instrumentation:classloaders:javaagent-integration-tests'
include ':instrumentation:classloaders:javaagent-unittests'
include ':instrumentation:classloaders:javaagent-unit-tests'
include ':instrumentation:couchbase:couchbase-2.0:javaagent'
include ':instrumentation:couchbase:couchbase-2.0:javaagent-unittests'
include ':instrumentation:couchbase:couchbase-2.0:javaagent-unit-tests'
include ':instrumentation:couchbase:couchbase-2.6:javaagent'
include ':instrumentation:couchbase:couchbase-3.1:javaagent'
include ':instrumentation:couchbase:couchbase-testing'
Expand All @@ -106,7 +106,7 @@ include ':instrumentation:elasticsearch:elasticsearch-transport-5.3:javaagent'
include ':instrumentation:elasticsearch:elasticsearch-transport-6.0:javaagent'
include ':instrumentation:executors:javaagent'
include ':instrumentation:external-annotations:javaagent'
include ':instrumentation:external-annotations:javaagent-unittests'
include ':instrumentation:external-annotations:javaagent-unit-tests'
include ':instrumentation:finatra-2.9:javaagent'
include ':instrumentation:geode-1.4:javaagent'
include ':instrumentation:google-http-client-1.19:javaagent'
Expand Down Expand Up @@ -147,7 +147,7 @@ include ':instrumentation:jaxws:jaxws-2.0-testing'
include ':instrumentation:jaxws:jaxws-common:library'
include ':instrumentation:jaxws:jws-1.1:javaagent'
include ':instrumentation:jdbc:javaagent'
include ':instrumentation:jdbc:javaagent-unittests'
include ':instrumentation:jdbc:javaagent-unit-tests'
include ':instrumentation:jedis:jedis-1.4:javaagent'
include ':instrumentation:jedis:jedis-3.0:javaagent'
include ':instrumentation:jetty:jetty-8.0:javaagent'
Expand All @@ -164,7 +164,7 @@ include ':instrumentation:kafka-streams-0.11:javaagent'
include ':instrumentation:khttp-0.1:javaagent'
include ':instrumentation:kotlinx-coroutines:javaagent'
include ':instrumentation:kubernetes-client-7.0:javaagent'
include ':instrumentation:kubernetes-client-7.0:javaagent-unittests'
include ':instrumentation:kubernetes-client-7.0:javaagent-unit-tests'
include ':instrumentation:lettuce:lettuce-common:library'
include ':instrumentation:lettuce:lettuce-4.0:javaagent'
include ':instrumentation:lettuce:lettuce-5.0:javaagent'
Expand Down Expand Up @@ -277,9 +277,9 @@ include ':benchmark-integration:jetty-perftest'
include ':benchmark-e2e'

def setBuildFile(project) {
// javaagent-unittests modules are needed until those projects have library modules
// at which time those unittests can be moved to the library modules
if (['javaagent', 'javaagent-unittests', 'library', 'testing'].contains(project.projectDir.name) && project.path != ':javaagent') {
// javaagent-unit-tests modules are needed until those projects have library modules
// at which time those unit tests can be moved to the library modules
if (['javaagent', 'javaagent-unit-tests', 'library', 'testing'].contains(project.projectDir.name) && project.path != ':javaagent') {
project.buildFileName = "${project.projectDir.parentFile.name}-${project.projectDir.name}.gradle"
} else {
project.buildFileName = "${project.name}.gradle"
Expand Down

0 comments on commit d741dc4

Please sign in to comment.