Skip to content

Commit

Permalink
Make Play smoke test work on Java 17 (#12464)
Browse files Browse the repository at this point in the history
  • Loading branch information
trask authored Oct 18, 2024
1 parent 67cb5f1 commit 3c32c6a
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions smoke-tests/images/play/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ plugins {
id("otel.spotless-conventions")

id("com.google.cloud.tools.jib")
// TODO (trask) this plugin doesn't support Play 2.9+, see https://github.com/gradle/playframework/issues/185
// once play 3.1 is released, we can update to https://github.com/orgs/playframework/discussions/12338
id("org.gradle.playframework") version "0.14"
}

Expand All @@ -23,6 +25,10 @@ play {

dependencies {
implementation("com.typesafe.play:play-guice_$scalaVer:$playVer")
// Guice 5.1 is needed for Java 17 support on Play 2.8, see https://github.com/playframework/playframework/releases/tag/2.8.15
// TODO (trask) remove these version overrides after updating to Play 2.9
implementation("com.google.inject:guice:5.1.0")
implementation("com.google.inject.extensions:guice-assistedinject:5.1.0")
implementation("com.typesafe.play:play-logback_$scalaVer:$playVer")
implementation("com.typesafe.play:filters-helpers_$scalaVer:$playVer")
}
Expand Down

0 comments on commit 3c32c6a

Please sign in to comment.