Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Still fixing PR creation #658

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Still fixing PR creation #658

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions .github/workflows/reusable-create-collector-contrib-pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,19 +85,13 @@ jobs:
git checkout -b $branch
git commit -a -m "$message"
git push --set-upstream origin $branch
gh pr create --title "$message" \
--body "$body" \
--repo open-telemetry/opentelemetry-collector-contrib \
--base main

- name: Add change log entry
env:
JMX_METRICS_VERSION: ${{ inputs.jmx-metrics-version }}
# this is the token used for "gh pr view" below
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
pull_request_number=$(gh pr view --json number --jq .number)
url=$(gh pr create --title "$message" \
--body "$body" \
--repo open-telemetry/opentelemetry-collector-contrib \
--base main)

pull_request_number=${url//*\//}

# see the template for change log entry file at
# https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/.chloggen/TEMPLATE.yaml
cat > .chloggen/add-jmx-metrics-gatherer-$JMX_METRICS_VERSION.yaml << EOF
Expand Down