Use a more efficient serializer and write bytes directly to disk #2138
+274
−150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of an intermediary byte array. The OTel Java SDK has a hand-coded and optimized serializer implementation that is well tested and used extensively. This PR switches to using that serializer. It is also more efficient to serialize directly to the file output stream instead of an intermediary byte array, so I used the same marshaling strategy used by the SDK and passed the marshaler down to the WritableFile.
zeitlinger
reviewed
Aug 20, 2025
| @@ -38,10 +38,11 @@ public static <T> ToDiskExporterBuilder<T> builder(Storage storage) { | |||
| return new ToDiskExporterBuilder<>(storage); | |||
| } | |||
|
|
|||
| public CompletableResultCode export(Collection<EXPORT_DATA> data) { | |||
| public synchronized CompletableResultCode export(Collection<EXPORT_DATA> data) { | |||
There was a problem hiding this comment.
The serializer is stateful now, plus it seems like a bad idea to allow multiple exports to be writing to disk concurrently anyway.
trask
approved these changes
Aug 20, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of an intermediary byte array.
The OTel Java SDK has a hand-coded and optimized serializer implementation that is well tested and used extensively. This PR switches to using that serializer.
It is also more efficient to serialize directly to the file output stream instead of an intermediary byte array, so I used the same marshaling strategy used by the SDK and passed the marshaler down to the WritableFile.
See relevant discussion here:
#1911