Skip to content

[ibm-mq-metrics] Connection errors counter #2122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 19, 2025

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Aug 15, 2025

Description:
Add a counter that records the number of times the connection was not… established successfully, with an error.code dimension recording the code of the error reported

Testing:

Tests the result of a bad connection in an isolated unit test.

@atoulme atoulme requested a review from a team as a code owner August 15, 2025 21:59
@github-actions github-actions bot requested a review from breedx-splk August 15, 2025 21:59
@otelbot-java-contrib
Copy link
Contributor

🔧 The result from spotlessApply was committed to the PR branch.

@atoulme atoulme force-pushed the add_connection_errors branch from f2c70c3 to 4d9a69d Compare August 15, 2025 22:12
@otelbot-java-contrib
Copy link
Contributor

🔧 The result from spotlessApply was committed to the PR branch.

Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Thanks!

@breedx-splk
Copy link
Contributor

Oh, test failures and rebase tho. :)

github-actions bot and others added 5 commits August 19, 2025 13:26
… established successfully, with an error.code dimension recording the code of the error reported
Co-authored-by: jason plumb <75337021+breedx-splk@users.noreply.github.com>
@atoulme atoulme force-pushed the add_connection_errors branch from 4cbe700 to ba20128 Compare August 19, 2025 20:35
@otelbot-java-contrib
Copy link
Contributor

🔧 The result from spotlessApply was committed to the PR branch.

@trask trask added this pull request to the merge queue Aug 19, 2025
Merged via the queue into open-telemetry:main with commit ad68129 Aug 19, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants