-
Notifications
You must be signed in to change notification settings - Fork 166
[ibm-mq-metrics] Connection errors counter #2122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔧 The result from spotlessApply was committed to the PR branch. |
f2c70c3
to
4d9a69d
Compare
🔧 The result from spotlessApply was committed to the PR branch. |
breedx-splk
reviewed
Aug 15, 2025
02b322b
to
4cbe700
Compare
breedx-splk
reviewed
Aug 19, 2025
...ntegrationTest/java/io/opentelemetry/ibm/mq/integration/tests/WMQMonitorIntegrationTest.java
Outdated
Show resolved
Hide resolved
breedx-splk
approved these changes
Aug 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable. Thanks!
Oh, test failures and rebase tho. :) |
… established successfully, with an error.code dimension recording the code of the error reported
Co-authored-by: jason plumb <75337021+breedx-splk@users.noreply.github.com>
4cbe700
to
ba20128
Compare
🔧 The result from spotlessApply was committed to the PR branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add a counter that records the number of times the connection was not… established successfully, with an error.code dimension recording the code of the error reported
Testing:
Tests the result of a bad connection in an isolated unit test.