-
Notifications
You must be signed in to change notification settings - Fork 166
add declarative config for baggage #2031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zeitlinger
wants to merge
4
commits into
open-telemetry:main
Choose a base branch
from
zeitlinger:baggage-declarative-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add declarative config for baggage #2031
zeitlinger
wants to merge
4
commits into
open-telemetry:main
from
zeitlinger:baggage-declarative-config
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f89cb52
to
507cef9
Compare
@jaydeluca please have a look |
trask
reviewed
Aug 18, 2025
trask
approved these changes
Aug 19, 2025
.../main/java/io/opentelemetry/contrib/baggage/processor/BaggageLogRecordComponentProvider.java
Show resolved
Hide resolved
0072c76
to
e4c885f
Compare
@zeitlinger 3 tests are still failing even after rerunning them, can you check? worried to merge and possibly make our flaky test situation worse |
should be addressed with #2152 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2013