Skip to content

Fix Extrema failure test#8338

Merged
pellared merged 5 commits into
open-telemetry:mainfrom
mujib77:fix/remove-obsolete-extrema-test
May 22, 2026
Merged

Fix Extrema failure test#8338
pellared merged 5 commits into
open-telemetry:mainfrom
mujib77:fix/remove-obsolete-extrema-test

Conversation

@mujib77

@mujib77 mujib77 commented May 14, 2026

Copy link
Copy Markdown
Contributor

The Extrema failure test referenced minA/minB variables that no longer exist, causing tests_fail builds to fail.

This removes the outdated test case.

@linux-foundation-easycla

linux-foundation-easycla Bot commented May 14, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: mujib77 / name: mujib77 (807da99)

@dashpole

Copy link
Copy Markdown
Collaborator

We should probably re-introduce the minA/minB variables in this file, rather than comment out the test

@mujib77

mujib77 commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

Thanks! That makes sense — I'll reintroduce the minA/minB variables and update the PR accordingly.

@mujib77

mujib77 commented May 16, 2026

Copy link
Copy Markdown
Contributor Author

Reintroduced the minA/minB extrema test variables and verified the tests build correctly with go test -tags tests_fail.

@dashpole dashpole added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 18, 2026
@pellared pellared changed the title Remove obsolete Extrema failure test Fix Extrema failure test May 22, 2026
@pellared pellared added this to the v1.44.0 milestone May 22, 2026
@codecov

codecov Bot commented May 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.9%. Comparing base (0f9ca98) to head (1651cfe).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #8338     +/-   ##
=======================================
- Coverage   82.9%   82.9%   -0.1%     
=======================================
  Files        314     314             
  Lines      25083   25083             
=======================================
- Hits       20798   20797      -1     
- Misses      3911    3912      +1     
  Partials     374     374             

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pellared pellared merged commit 6ceeae8 into open-telemetry:main May 22, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants