Fix Extrema failure test#8338
Merged
pellared merged 5 commits intoMay 22, 2026
Merged
Conversation
|
|
Collaborator
|
We should probably re-introduce the minA/minB variables in this file, rather than comment out the test |
Contributor
Author
|
Thanks! That makes sense — I'll reintroduce the minA/minB variables and update the PR accordingly. |
Contributor
Author
|
Reintroduced the minA/minB extrema test variables and verified the tests build correctly with |
dashpole
approved these changes
May 18, 2026
pellared
approved these changes
May 22, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8338 +/- ##
=======================================
- Coverage 82.9% 82.9% -0.1%
=======================================
Files 314 314
Lines 25083 25083
=======================================
- Hits 20798 20797 -1
- Misses 3911 3912 +1
Partials 374 374 🚀 New features to boost your workflow:
|
XSAM
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Extrema failure test referenced minA/minB variables that no longer exist, causing tests_fail builds to fail.
This removes the outdated test case.