-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Optimize histogram reservoir #7443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dashpole
wants to merge
5
commits into
open-telemetry:main
Choose a base branch
from
dashpole:optimize_histogram_reservoir
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Optimize histogram reservoir #7443
dashpole
wants to merge
5
commits into
open-telemetry:main
from
dashpole:optimize_histogram_reservoir
+53
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7443 +/- ##
=====================================
Coverage 85.7% 85.7%
=====================================
Files 287 287
Lines 25347 25359 +12
=====================================
+ Hits 21744 21757 +13
+ Misses 3222 3220 -2
- Partials 381 382 +1
🚀 New features to boost your workflow:
|
512b67e
to
a7d395d
Compare
This was referenced Oct 2, 2025
864211f
to
6497b59
Compare
MrAlias
reviewed
Oct 3, 2025
7457c73
to
7c1476f
Compare
7c1476f
to
7b79e43
Compare
dashpole
added a commit
that referenced
this pull request
Oct 7, 2025
Forked from this discussion here: #7443 (comment) It seems like a good idea for us as a group to align on and document what we are comfortable with in terms of how ordered measurements are reflected in collected metric data. --------- Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
MrAlias
approved these changes
Oct 7, 2025
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the concurrent performance of the histogram reservoir's Offer function by 10x (i.e. 90% reduction).
Accomplish this by:
Depends on #7441. Marking as a draft until that is merged.