Move Resource into the metric export Record #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
Aneurysm9,
evantorrie,
lizthegrey,
MrAlias and
paivagustavo
as code owners
MrAlias
approved these changes
May 18, 2020
jmacd
force-pushed
the
jmacd/res_in_export_rec
branch
2 times, most recently
from
6317d15
to
a96606b
Compare
jmacd
force-pushed
the
jmacd/res_in_export_rec
branch
2 times, most recently
from
b8e1ff7
to
e2126bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in open-telemetry/opentelemetry-specification#508
This makes it significantly easier to share a exporter between multiple SDKs. This adds testing for resources in various places.