[WIP] Bad log message fix and refactor #6987
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shri-acha
requested review from
MrAlias,
XSAM,
dashpole,
pellared and
dmathieu
as code owners
pellared
reviewed
Jul 15, 2025
|
I've made the changes @pellared . I'm still unsure about how I have to deal with the tests. |
Can you please update the branch and resolve conficts?
Update/fix them if they do not test the expected behavior. Also add any missing ones (e.g. for the new log message). It would be also good to add a test for regression that the log messages are not emitted when everything is fine (no deduplication and none limit has been exceeded). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the log messages for now, have to work on removing the drop count as will be discussed in #6983 .