Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate non-retryable error messages to client #5929

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Propagate non-retryable error messages to client #5929

wants to merge 2 commits into from
+193 −89

Commits on Nov 6, 2024

  1. log, metric, trace clients: close body uniformly 

    There were inconsistencies in closing the response body. For traces, the
Close happened in a defer statement and any error was logged. Logs and
metrics were less rigorous. It appeared Close() wasn't always called,
and when it was, errors were returned sometimes and ignored at other
times.

This applies the defer logic from traces to the other two and removes
other Close() calls.
    @mark-pictor-csec
    mark-pictor-csec committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    552b101 View commit details
    Browse the repository at this point in the history

  2. Propagate non-retryable error messages to client 

    PR open-telemetry#5541 (and issue open-telemetry#5536) enhance error handling, returning body text
as part of the error. However, this is only done for retryable errors;
if non-retryable, error text still does not propagate to clients.

This PR adds handling of non-retryable errors, ensuring any body text is
part of the message returned to the user's code. There is no change to
the circumstances under which errors are reported, just an enhancement
of the content of such an error.
    @mark-pictor-csec
    mark-pictor-csec committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    4c276b1 View commit details
    Browse the repository at this point in the history