-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cheng-Zhen as a triager #5922
Merged
dmathieu
merged 3 commits into
open-telemetry:main
from
dmathieu:scorpionknifes-triager
Oct 28, 2024
Merged
Add Cheng-Zhen as a triager #5922
dmathieu
merged 3 commits into
open-telemetry:main
from
dmathieu:scorpionknifes-triager
Oct 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
requested review from
MrAlias,
XSAM,
dashpole and
pellared
as code owners
October 25, 2024 08:05
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dmathieu!
scorpionknifes
approved these changes
Oct 25, 2024
dmathieu
force-pushed
the
scorpionknifes-triager
branch
from
October 25, 2024 08:49
6c132a8
to
5a9c462
Compare
MrAlias
approved these changes
Oct 25, 2024
dashpole
approved these changes
Oct 25, 2024
pellared
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
pellared
pushed a commit
to open-telemetry/opentelemetry-go-contrib
that referenced
this pull request
Oct 29, 2024
Follows open-telemetry/opentelemetry-go#5922 Remove affiliations from the emeritus maintainers, following open-telemetry/opentelemetry-go#5887
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposes adding @scorpionknifes as a triager for the Go SIG.
While Cheng-Zhen's contributions are all in the contrib repository, we don't currently split roles between the two repos.
Cheng-Zhen's contributions in the log bridges, and his interest in being more involved with the SIG make him a nice fit to be a triager.