sdk/instrumentation: Add Attributes to Scope #5903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5903 +/- ##
=====================================
Coverage 84.6% 84.6%
=====================================
Files 272 272
Lines 22839 22839
=====================================
Hits 19325 19325
Misses 3170 3170
Partials 344 344 |
pellared
changed the title
pellared
requested review from
MrAlias,
XSAM,
dashpole and
dmathieu
as code owners
dashpole
approved these changes
Oct 28, 2024
dmathieu
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #3368
Pre-work: #5806
API change:
Attributes attribute.Setfield toinstrumentation.Scope,logtest.ScopeRecordsI decided to make as small PRs as possible for sake of easier reviews.
Next PRs are going to make the scope attributes as identifying for Tracer, Meter, Logger in SDK (3 PRs).
Then following PRs are going to emit the scope attributes via exporters.
Doing everything in one PR is too much. See: #5806