Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify that users should not directly use the log bridge API #5837

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

dashpole
Copy link
Contributor

Fixes #5681

@dashpole dashpole added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.5%. Comparing base (d284a86) to head (1063bff).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5837   +/-   ##
=====================================
  Coverage   84.5%   84.5%           
=====================================
  Files        272     272           
  Lines      22734   22734           
=====================================
  Hits       19226   19226           
  Misses      3165    3165           
  Partials     343     343           

Copy link
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we shouldn't try to emphasize the warning a bit more?

@pellared
Copy link
Member

I wonder if we shouldn't try to emphasize the warning a bit more?

I think it is good enough. Moreover, I expect this API would be in future will be used for emitting OTel events without using a bridge in between.

log/doc.go Outdated Show resolved Hide resolved
Co-authored-by: Robert Pająk <pellared@hotmail.com>
@dashpole dashpole changed the title clarify that users should not durectly use the log bridge API clarify that users should not directly use the log bridge API Sep 24, 2024
@pellared pellared merged commit 84677a6 into open-telemetry:main Sep 25, 2024
32 checks passed
@MrAlias MrAlias added this to the v1.31.0 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit Compliance: Logs Bridge API Artifact Naming
4 participants