-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate semconv codegen to weaver #5793
Draft
jsuereth
wants to merge
8
commits into
open-telemetry:main
Choose a base branch
from
jsuereth:wip-use-weaver
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5793 +/- ##
=======================================
- Coverage 84.6% 84.6% -0.1%
=======================================
Files 272 272
Lines 22759 22778 +19
=======================================
+ Hits 19255 19271 +16
- Misses 3164 3166 +2
- Partials 340 341 +1 |
16 tasks
This was referenced Sep 16, 2024
This was referenced Oct 18, 2024
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prototype for discussion and demonstration in next week's Go SiG meeting.
This migrates semconv codegeneration off the (deprecated, soon to be abandoned) semconvgen to weaver.
A few things in this PR:
I couldn't find (easily) the documentation you had previously for generating semconv (which I did find in the collect). This should make it as easy as:
which is how I generated the v1.27.0 code here.
Regarding JINJA formatting, I didn't have a chance to go through whitespace refactoring/fun. For other codegen we run formatting tools as part of the makefile. I've manually run
go fmt
on the generated code, but we would likely want to have that a part of the Makefile to automatically correct Jinja's wierd whitespacing.