Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run ConcurrentSafe tests multiple times in CI #5759

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

XSAM
Copy link
Member

@XSAM XSAM commented Aug 30, 2024

This test has a high possibility of detecting issues like #5757. https://github.com/open-telemetry/opentelemetry-go/actions/runs/10635489400/job/29485188862?pr=5759

We need to merge fixes of #5757, like #5758, first.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.6%. Comparing base (a1c63a7) to head (bd94606).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5759   +/-   ##
=====================================
  Coverage   84.6%   84.6%           
=====================================
  Files        272     272           
  Lines      22759   22759           
=====================================
  Hits       19255   19255           
  Misses      3164    3164           
  Partials     340     340           

@XSAM XSAM merged commit 48fedfa into open-telemetry:main Sep 4, 2024
32 checks passed
@XSAM XSAM deleted the add-test-concurrent-safe branch September 4, 2024 00:09
XSAM added a commit that referenced this pull request Sep 5, 2024
Related #5759

---------

Co-authored-by: Robert Pająk <pellared@hotmail.com>
@XSAM XSAM added this to the v1.30.0 milestone Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants