Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an implementation of the Header* filters that does not depend on go1.14 #565

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

Aneurysm9
Copy link
Member

No description provided.

Copy link
Member

@lizthegrey lizthegrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there tests for this?

@Aneurysm9
Copy link
Member Author

There are tests for the filter. https://github.com/open-telemetry/opentelemetry-go/blob/master/plugin/othttp/filters/filters_test.go I'm not familiar enough with CircleCI to be comfortable updating the build spec to run against Go1.13, but the 1.14 tests are passing.

@jmacd jmacd merged commit e0406dd into open-telemetry:master Mar 17, 2020
@Aneurysm9 Aneurysm9 deleted the fix_header_filter branch March 17, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants