stdoutlog: Add exporter #5172
Merged
stdoutlog: Add exporter #5172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XSAM
requested review from
MrAlias,
Aneurysm9,
evantorrie,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5172 +/- ##
=====================================
Coverage 83.9% 83.9%
=====================================
Files 256 258 +2
Lines 16601 16647 +46
=====================================
+ Hits 13938 13980 +42
- Misses 2370 2373 +3
- Partials 293 294 +1
|
MrAlias
reviewed
Apr 7, 2024
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
pellared
reviewed
Apr 7, 2024
pellared
reviewed
Apr 7, 2024
pellared
reviewed
Apr 7, 2024
Co-authored-by: Robert Pająk <pellared@hotmail.com>
dmathieu
reviewed
Apr 8, 2024
pellared
reviewed
Apr 8, 2024
Co-authored-by: Damien Mathieu <42@dmathieu.com>
MrAlias
approved these changes
Apr 8, 2024
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
pellared
requested changes
Apr 9, 2024
There was a problem hiding this comment.
Only one blocking comment: https://github.com/open-telemetry/opentelemetry-go/pull/5172/files#r1555877107
pellared
previously approved these changes
Apr 10, 2024
pellared
reviewed
Apr 10, 2024
pellared
reviewed
Apr 10, 2024
pellared
approved these changes
Apr 10, 2024
dmathieu
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parts of #5055