-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add READMEs to every package #5103
Add READMEs to every package #5103
Conversation
All link issues are 429s from pkg.go.dev. I'll rerun this in a bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this 👍
Are we moving away from package being is go files? I thought the group decided to not straddle having it there and in a README.md? |
The proposal is to have readme files that would just refer to pkg.go.dev. |
Can we clarify in our contributing guidelines that we do not add documentation to the readme and Go docs? |
Sure. How about the current wording? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this a lot
I have moved the check to a script executable from the Makefile, and added it to open-telemetry/opentelemetry-go› git:(readme-for-all-packages) 3D2M 1A make verify-readmes
./verify_readmes.sh
couldn't find README.md for ./bridge/opencensus
couldn't find README.md for ./bridge/opentracing
Error: some READMEs couldn't be found.
make: *** [verify-readmes] Error 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏅
Replacement for #5102.