Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add READMEs to every package #5103

Merged
merged 16 commits into from
Mar 26, 2024
Merged

Add READMEs to every package #5103

merged 16 commits into from
Mar 26, 2024

Conversation

dmathieu
Copy link
Member

Replacement for #5102.

@dmathieu dmathieu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 25, 2024
@dmathieu
Copy link
Member Author

All link issues are 429s from pkg.go.dev. I'll rerun this in a bit.

Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this 👍

.github/workflows/scripts/readme.sh Outdated Show resolved Hide resolved
.github/workflows/scripts/readme.sh Outdated Show resolved Hide resolved
.github/workflows/scripts/readme.sh Outdated Show resolved Hide resolved
.github/workflows/scripts/readme.sh Outdated Show resolved Hide resolved
@MrAlias
Copy link
Contributor

MrAlias commented Mar 25, 2024

Are we moving away from package being is go files? I thought the group decided to not straddle having it there and in a README.md?

@pellared
Copy link
Member

Are we moving away from package being is go files? I thought the group decided to not straddle having it there and in a README.md?

The proposal is to have readme files that would just refer to pkg.go.dev.
See:

@MrAlias
Copy link
Contributor

MrAlias commented Mar 25, 2024

Are we moving away from package being is go files? I thought the group decided to not straddle having it there and in a README.md?

The proposal is to have readme files that would just refer to pkg.go.dev. See:

Can we clarify in our contributing guidelines that we do not add documentation to the readme and Go docs?

@dmathieu
Copy link
Member Author

Can we clarify in our contributing guidelines that we do not add documentation to the readme and Go docs?

Sure. How about the current wording?

.github/workflows/scripts/readme.sh Outdated Show resolved Hide resolved
.github/workflows/scripts/readme.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot

@dmathieu
Copy link
Member Author

I have moved the check to a script executable from the Makefile, and added it to make precommit.
The script will also now run through each package, output for any that fails, and exit with an error if any failed.

open-telemetry/opentelemetry-go›  git:(readme-for-all-packages) 3D2M 1A make verify-readmes
./verify_readmes.sh
couldn't find README.md for ./bridge/opencensus
couldn't find README.md for ./bridge/opentracing
Error: some READMEs couldn't be found.
make: *** [verify-readmes] Error 1

Makefile Outdated Show resolved Hide resolved
.github/workflows/readme.yml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

CONTRIBUTING.md Outdated Show resolved Hide resolved
@pellared pellared merged commit edb788b into open-telemetry:main Mar 26, 2024
27 checks passed
@dmathieu dmathieu deleted the readme-for-all-packages branch March 27, 2024 08:48
@MrAlias MrAlias added this to the v1.25.0 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants