Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the BatchingProcessor configuration #5088

Merged
merged 13 commits into from
Mar 25, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Mar 19, 2024

Part of #5063

The existing limit type from the provider configuration is refactored into a more generalized setting type. This new type is used in both the existing providerConfig and the implemented batchingConfig.

@MrAlias MrAlias added area:logs Part of OpenTelemetry logs Skip Changelog PRs that do not require a CHANGELOG.md entry labels Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.8%. Comparing base (8b14747) to head (da5a060).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #5088     +/-   ##
=======================================
+ Coverage   83.6%   83.8%   +0.1%     
=======================================
  Files        247     248      +1     
  Lines      16087   16147     +60     
=======================================
+ Hits       13455   13537     +82     
+ Misses      2344    2322     -22     
  Partials     288     288             
Files Coverage Δ
sdk/log/batch.go 88.4% <100.0%> (+88.4%) ⬆️
sdk/log/provider.go 100.0% <100.0%> (ø)
sdk/log/setting.go 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MrAlias MrAlias merged commit 32e3a3d into open-telemetry:main Mar 25, 2024
27 checks passed
@MrAlias MrAlias deleted the blrp-conf branch March 25, 2024 14:50
@MrAlias MrAlias added this to the v1.25.0 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:logs Part of OpenTelemetry logs Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants