sdk/trace: fix grammar errors #4996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also use the 'par' program to better align the line breaks in the paragraph doc comments.
kevinburkesegment
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
|
What spelling mistakes is this addressing? I only see an alternate line break formatting being proposed here. |
|
Sorry, here.
used to be "make" and "feature". |
kevinburkesegment
changed the title
|
Can you revert the line break changes and just include the grammatical fixes you want to apply? It will help reviews. |
pellared
approved these changes
Mar 6, 2024
|
@kevinburkesegment Are you able to address #4996 (comment)? |
hanyuancheung
approved these changes
Mar 23, 2024
dmathieu
approved these changes
Mar 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4996 +/- ##
=====================================
Coverage 83.6% 83.6%
=====================================
Files 247 247
Lines 16087 16087
=====================================
+ Hits 13455 13457 +2
+ Misses 2344 2342 -2
Partials 288 288
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also use the 'par' program to better align the line breaks in the paragraph doc comments.