Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Go 1.20 #4967

Merged
merged 14 commits into from
Feb 25, 2024
Merged

Drop support for Go 1.20 #4967

merged 14 commits into from
Feb 25, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Feb 23, 2024

Resolve #4819

@MrAlias MrAlias added this to the v1.25.0 milestone Feb 23, 2024
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 32.65306% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 82.9%. Comparing base (8fb28b5) to head (50907f6).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4967   +/-   ##
=====================================
  Coverage   82.9%   82.9%           
=====================================
  Files        238     238           
  Lines      19167   19127   -40     
=====================================
- Hits       15891   15858   -33     
+ Misses      2984    2980    -4     
+ Partials     292     289    -3     
Files Coverage Δ
log/keyvalue.go 97.8% <100.0%> (-0.2%) ⬇️
log/record.go 100.0% <100.0%> (ø)
sdk/trace/span.go 88.0% <100.0%> (+0.7%) ⬆️
...dk/metric/metricdata/metricdatatest/comparisons.go 92.1% <23.2%> (+0.2%) ⬆️

Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MrAlias MrAlias merged commit 561714a into open-telemetry:main Feb 25, 2024
24 of 25 checks passed
@MrAlias MrAlias deleted the rm-go-1.20 branch February 25, 2024 18:48
@MrAlias MrAlias mentioned this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace ensureAttributesCapacity with slices.Grow
3 participants