-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logs SDK prototype #4955
Closed
Closed
Logs SDK prototype #4955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4955 +/- ##
=======================================
- Coverage 83.4% 82.6% -0.8%
=======================================
Files 238 246 +8
Lines 15745 16108 +363
=======================================
+ Hits 13143 13318 +175
- Misses 2314 2482 +168
- Partials 288 308 +20
|
pellared
added
Skip Changelog
PRs that do not require a CHANGELOG.md entry
area:logs
Part of OpenTelemetry logs
pkg:SDK
Related to an SDK package
labels
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:logs
Part of OpenTelemetry logs
pkg:SDK
Related to an SDK package
Skip Changelog
PRs that do not require a CHANGELOG.md entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #4896
The design doc PR: #4954
Current benchmark results:
Side note:
There was one allocation if the context has no span. 29c90a0 I will submit a separate PR to fix it.