Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design: log value accessors must not panic #4948

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

pellared
Copy link
Member

@pellared pellared commented Feb 20, 2024

Towards #4914

I also updated the prototype with 147762f

@pellared pellared added the area:logs Part of OpenTelemetry logs label Feb 20, 2024
@pellared pellared added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 20, 2024
Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure this is necessary to have in the design doc, but i'm not against it if you think that was unclear.

@pellared
Copy link
Member Author

I'm not entirely sure this is necessary to have in the design doc, but i'm not against it if you think that was unclear.

I think it won't hurt and documents why it is different than e.g. slog's value accessors: https://pkg.go.dev/log/slog#Value.Bool

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dd3b00f) 82.6% compared to head (5694a90) 82.6%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4948     +/-   ##
=======================================
- Coverage   82.6%   82.6%   -0.1%     
=======================================
  Files        238     238             
  Lines      19036   19036             
=======================================
- Hits       15742   15740      -2     
- Misses      3003    3005      +2     
  Partials     291     291             

see 1 file with indirect coverage changes

@pellared pellared merged commit c2fdbca into open-telemetry:main Feb 21, 2024
30 checks passed
@pellared pellared deleted the log-design-value-accessors branch February 21, 2024 06:02
@MrAlias MrAlias added this to the v1.24.0 milestone Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:logs Part of OpenTelemetry logs Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants