Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): explicitly mark lizthegrey emeritus #4822

Merged
merged 4 commits into from
Jan 12, 2024

Conversation

lizthegrey
Copy link
Member

@lizthegrey lizthegrey commented Jan 12, 2024

Follow-on to #1745 - we didn't have an emeritus section then, but we do now as of #2888.

(also, hi, it's good to be contributing again, I feel no need to be an approver, I just have fond memories of helping kickstart this thing.)

Follow-on to open-telemetry#1745 - we didn't have an emeritus section then, but we do now as of open-telemetry#2888.
@lizthegrey
Copy link
Member Author

lizthegrey commented Jan 12, 2024

Please flag "skip changelog", I don't even have those rights to edit tags any more 😭

@dmathieu dmathieu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 12, 2024
@dmathieu
Copy link
Member

Nit, but is the order correct? Shouldn't you be before @jmacd ?
Or should we sort the list alphabetically?

@lizthegrey
Copy link
Member Author

Nit, but is the order correct? Shouldn't you be before @jmacd ? Or should we sort the list alphabetically?

Done

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7fa7d1b) 82.3% compared to head (d65f5ab) 82.3%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4822   +/-   ##
=====================================
  Coverage   82.3%   82.3%           
=====================================
  Files        226     226           
  Lines      18410   18410           
=====================================
+ Hits       15157   15159    +2     
+ Misses      2969    2967    -2     
  Partials     284     284           

see 1 file with indirect coverage changes

@MrAlias MrAlias added the documentation Provides helpful information label Jan 12, 2024
@MrAlias MrAlias merged commit 19622d3 into open-telemetry:main Jan 12, 2024
27 checks passed
@lizthegrey lizthegrey deleted the lizf.emeritus branch January 12, 2024 18:29
@XSAM XSAM added this to the Old Untracked PRs milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Provides helpful information Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants