Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baggage: Member.String encodes only when necessary #4775

Merged
merged 10 commits into from
Dec 28, 2023
Merged

baggage: Member.String encodes only when necessary #4775

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7799bf6
baggage: Member.String encodes only when necessary
pellared Dec 21, 2023
b0ac2e9
Update changelog
pellared Dec 21, 2023
c117cd7
Add UTF-8 test cases
pellared Dec 21, 2023
73154a1
Add benchmarks
pellared Dec 21, 2023
be7a560
Fix BenchmarkValueEscape
pellared Dec 21, 2023
908cbc7
Fix
pellared Dec 21, 2023
9c0046b
Refactor BenchmarkValueEscape
pellared Dec 21, 2023
c660273
Move upperhex near usage
pellared Dec 21, 2023
06ff3c2
Merge branch 'main' into impr-baggage-member-string
pellared Dec 27, 2023
005ba1b
Merge branch 'main' into impr-baggage-member-string
pellared Dec 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move upperhex near usage
  • Loading branch information
@pellared
pellared committed Dec 21, 2023
commit c660273d0a30a012fef6b62a1f50d4a56a802e7e
3 changes: 1 addition & 2 deletions baggage/baggage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,6 +691,7 @@ func valueEscape(s string) string {
for i := 0; i < len(s); i++ {
c := s[i]
if shouldEscape(s[i]) {
const upperhex = "0123456789ABCDEF"
t[j] = '%'
t[j+1] = upperhex[c>>4]
t[j+2] = upperhex[c&15]
Expand All @@ -713,5 +714,3 @@ func shouldEscape(c byte) bool {
}
return !validateValueChar(int32(c))
}

const upperhex = "0123456789ABCDEF"