-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdk/metric: Fix observable not registered error when the asynchronous instrument has a drop aggregation #4772
Merged
MrAlias
merged 16 commits into
open-telemetry:main
from
scorpionknifes:fix-drop-aggregation-observer-error
Jan 11, 2024
Merged
sdk/metric: Fix observable not registered error when the asynchronous instrument has a drop aggregation #4772
MrAlias
merged 16 commits into
open-telemetry:main
from
scorpionknifes:fix-drop-aggregation-observer-error
Jan 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scorpionknifes
changed the title
WIP: Fix observable instrument not registered on drop aggregation
sdk/metric: Fix observable not registered error during drop aggregation
Dec 20, 2023
scorpionknifes
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
December 20, 2023 08:39
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4772 +/- ##
=====================================
Coverage 82.3% 82.3%
=====================================
Files 226 226
Lines 18406 18410 +4
=====================================
+ Hits 15153 15157 +4
Misses 2969 2969
Partials 284 284
|
pellared
reviewed
Dec 20, 2023
pellared
reviewed
Dec 20, 2023
scorpionknifes
changed the title
sdk/metric: Fix observable not registered error during drop aggregation
sdk/metric: Fix observable not registered error when the asynchronous instrument has a drop aggregation
Dec 20, 2023
pellared
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just nit comments.
@MrAlias @MadVikingGod @dashpole, can you check if the way how it is fixed in meter.go
and instrument.go
is acceptable?
hanyuancheung
approved these changes
Jan 2, 2024
MrAlias
requested changes
Jan 8, 2024
MrAlias
reviewed
Jan 10, 2024
MrAlias
reviewed
Jan 11, 2024
MrAlias
approved these changes
Jan 11, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4666
When an observable instrument is dropped by view drop aggregation, it prints
observable instrument not registered for callback message
, as the instrument isn't register due to it being dropped.opentelemetry-go/sdk/metric/meter.go
Lines 472 to 480 in cb8cb2d
This PR attempts to ignore the above code by adding a flag to the observable instrument indicating it has been dropped and ignoring registered check