Add StartOptions to Tracer.WithSpan() #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tracer.WithSpan() will now accept StartOptions as a variadic final parameter `opts` that will be passed to the Tracer.Start() invocation that creates the Span wrapping the user-provided function.
Aneurysm9
requested review from
iredelmeier,
jmacd,
krnowak,
lizthegrey,
paivagustavo,
rghetia and
tedsuo
as code owners
lizthegrey
approved these changes
Feb 11, 2020
lizthegrey
added
the
blocked:CLA
|
CLA signed. |
paivagustavo
approved these changes
Feb 11, 2020
paivagustavo
removed
the
blocked:CLA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracer.WithSpan() will now accept StartOptions as a variadic final parameter
optsthat will be passed to the Tracer.Start() invocation that creates the Span
wrapping the user-provided function.
Fixes #149.