Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otlptracegrpc, otlpmetricgrpc: Retry for RESOURCE_EXHAUSTED only if RetryInfo is returned #4669

Merged
merged 8 commits into from
Oct 30, 2023
Merged

otlptracegrpc, otlpmetricgrpc: Retry for RESOURCE_EXHAUSTED only if RetryInfo is returned #4669

merged 8 commits into from
Oct 30, 2023

Conversation

pellared
Copy link
Member

@pellared pellared commented Oct 27, 2023 •
edited
Loading

Fixes #4661

@pellared pellared changed the title otlptracegrpc, otlpmetricgrpc: Handle RESOURCE_EXHAUSTED only if RetryInfo is returned otlptracegrpc, otlpmetricgrpc: Retry for RESOURCE_EXHAUSTED only if RetryInfo is returned Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023 •
edited
Loading

Codecov Report

Merging #4669 (b63507b) into main (509c23e) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4669   +/-   ##
=====================================
  Coverage   81.6%   81.6%           
=====================================
  Files        225     225           
  Lines      17969   17983   +14     
=====================================
+ Hits       14668   14682   +14     
  Misses      3001    3001           
  Partials     300     300
Files Coverage Δ
exporters/otlp/otlpmetric/otlpmetricgrpc/client.go 91.5% <100.0%> (+0.5%) ⬆️
exporters/otlp/otlptrace/otlptracegrpc/client.go 92.9% <100.0%> (+0.3%) ⬆️

@pellared pellared marked this pull request as ready for review October 27, 2023 11:09
dashpole
dashpole reviewed Oct 27, 2023
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@pellared @MrAlias
Update exporters/otlp/otlpmetric/otlpmetricgrpc/client.go
1a6c177 
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@pellared pellared requested a review from MrAlias October 30, 2023 18:55
@pellared @MrAlias
Apply suggestions from code review
b63507b 
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@pellared pellared requested a review from MrAlias October 30, 2023 20:23
@pellared pellared merged commit aea3eab into open-telemetry:main Oct 30, 2023
25 checks passed
@pellared pellared mentioned this pull request Nov 10, 2023
Merged
@pellared pellared deleted the fix-4661 branch November 17, 2023 09:00
@XSAM XSAM added this to the Old Untracked PRs milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias approved these changes

@dashpole dashpole dashpole approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
untracked
Development

Successfully merging this pull request may close these issues.

otlptracegrpc otlpmetricgrpc: Handling RESOURCE_EXHAUSTED
4 participants
@pellared @dashpole @MrAlias @XSAM