Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scope version to opencensus trace and metric bridges #4584

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Add scope version to opencensus trace and metric bridges #4584

merged 3 commits into from
Oct 11, 2023

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Oct 3, 2023

Fixes #4573

@dashpole dashpole added enhancement New feature or request pkg:bridges Related to a bridge package labels Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023 •
edited
Loading

Codecov Report

Merging #4584 (3d69d8b) into main (3f17bcb) will increase coverage by 0.0%.
The diff coverage is 88.8%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4584   +/-   ##
=====================================
  Coverage   81.3%   81.3%           
=====================================
  Files        221     222    +1     
  Lines      17686   17692    +6     
=====================================
+ Hits       14391   14399    +8     
+ Misses      2995    2993    -2     
  Partials     300     300
Files Coverage Δ
bridge/opencensus/metric.go 100.0% <100.0%> (ø)
bridge/opencensus/version.go 100.0% <100.0%> (ø)
bridge/opencensus/trace.go 38.4% <80.0%> (+38.4%) ⬆️

@pellared pellared merged commit 1074d64 into open-telemetry:main Oct 11, 2023
24 checks passed
@MrAlias MrAlias added this to the v1.20.0 milestone Oct 30, 2023
@pellared pellared mentioned this pull request Nov 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanyuancheung hanyuancheung hanyuancheung approved these changes

@pellared pellared pellared approved these changes

@dmathieu dmathieu dmathieu approved these changes

@MrAlias MrAlias Awaiting requested review from MrAlias MrAlias is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod

Assignees
No one assigned
Labels
enhancement New feature or request pkg:bridges Related to a bridge package
Projects
No open projects
Go: Metric OpenCensus Bridge (GA)
Status: Done
Milestone
v1.20.0
Development

Successfully merging this pull request may close these issues.

OpenCensus bridge MUST add a scope version
5 participants
@dashpole @dmathieu @pellared @hanyuancheung @MrAlias