-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow '/' character in instrument names #4501
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
September 12, 2023 15:52
aabmass
force-pushed
the
allow-slash-4500
branch
from
September 12, 2023 15:53
b1e6bbf
to
4b2c519
Compare
MrAlias
approved these changes
Sep 12, 2023
Can you add a changelog entry for this please? |
Codecov Report
@@ Coverage Diff @@
## main #4501 +/- ##
=======================================
- Coverage 81.3% 81.3% -0.1%
=======================================
Files 220 220
Lines 17670 17670
=======================================
- Hits 14378 14376 -2
- Misses 2992 2994 +2
Partials 300 300
|
pellared
approved these changes
Sep 12, 2023
Done |
MrAlias
reviewed
Sep 12, 2023
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
dmathieu
approved these changes
Sep 12, 2023
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4500