-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flatten sdk/metric/aggregation
into sdk/metric
#4435
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
pkg:SDK
Related to an SDK package
area:metrics
Part of OpenTelemetry Metrics
labels
Aug 10, 2023
MrAlias
force-pushed
the
dep-aggregation-pkg
branch
from
August 10, 2023 20:34
f759f17
to
38420d7
Compare
MrAlias
force-pushed
the
dep-aggregation-pkg
branch
from
August 10, 2023 21:01
b25409b
to
44d86ea
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4435 +/- ##
=====================================
Coverage 78.8% 78.9%
=====================================
Files 253 254 +1
Lines 20668 20650 -18
=====================================
- Hits 16307 16305 -2
+ Misses 4012 4000 -12
+ Partials 349 345 -4
|
MrAlias
requested review from
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
August 10, 2023 21:09
pellared
approved these changes
Aug 11, 2023
I approved as I am going on PTO and the comments to be addressed are trivial. |
dashpole
reviewed
Aug 11, 2023
I like the move overall. Sum -> AggregationSum needs to be fixed |
Co-authored-by: Robert Pająk <pellared@hotmail.com>
dashpole
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #4432
Aggregation
interface and its implementations tosdk/metric
Aggregation
interfaceAggregation
to all concrete implementations of theAggregation
interfacesdk/metric/aggregation
pkgsdk/metric/internal/aggregate
from the aggregation types so there is no import cycleAggregator
in the metric exporterssdk/metric/aggregation
withsdk/metric